Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --license arg #38

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Add support for --license arg #38

merged 4 commits into from
Aug 29, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Aug 29, 2024

Add support for --license arg required by Remix IDE
Upload resolc artifact

@smiasojed smiasojed changed the title Remix Remix integration Aug 29, 2024
@smiasojed smiasojed changed the title Remix integration Add support for --license arg Aug 29, 2024
@smiasojed smiasojed marked this pull request as ready for review August 29, 2024 13:34
Comment on lines 48 to 50
- name: Build resolc
run: make install-bin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be required? Since the test-* targets do it anyways

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, fixed

@xermicus xermicus merged commit 41c8d4e into main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants