address review comment

paritytech · Dec 19, 2023 · f6cc8ad · f6cc8ad
1 parent 4f77197
commit f6cc8ad
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/reed-solomon-novelpoly/src/field/inc_encode.rs b/reed-solomon-novelpoly/src/field/inc_encode.rs
@@ -190,9 +190,7 @@ pub fn encode_sub_plain(bytes: &[u8], n: usize, k: usize) -> Result<Vec<Additive
 	// so we get a buffer of size `N` in `GF` symbols
 	let mut elm_data = vec![Additive(0); n];
 
-	let tmp = if bytes_len % 2 == 0 { bytes_len / 2 } else { (bytes_len + 1) / 2 };
-
-	for i in 0..tmp {
+	for i in 0..((bytes_len + 1) / 2) {
 		elm_data[i] = Additive(Elt::from_be_bytes([
 			bytes.get(2 * i).copied().unwrap_or_default(),
 			bytes.get(2 * i + 1).copied().unwrap_or_default(),
@@ -243,9 +241,7 @@ pub fn encode_sub_faster8(bytes: &[u8], n: usize, k: usize) -> Result<Vec<Additi
 	// so we get a buffer of size `N` in `GF` symbols
 	let mut elm_data = vec![Additive(0); n];
 
-	let tmp = if bytes_len % 2 == 0 { bytes_len / 2 } else { (bytes_len + 1) / 2 };
-
-	for i in 0..tmp {
+	for i in 0..((bytes_len + 1) / 2) {
 		elm_data[i] = Additive(Elt::from_be_bytes([
 			bytes.get(2 * i).map(|x| *x).unwrap_or_default(),
 			bytes.get(2 * i + 1).map(|x| *x).unwrap_or_default(),