-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps in staking-miner-playground #773
chore: update deps in staking-miner-playground #773
Conversation
…d-update-deps' into na-chore-staking-miner-playground-update-deps
…r-playground-update-deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed because the configurable block weight/length
doesn't work when running it with subxt because it relies on the metadata and this has no effect.
The only way is to change block length and block weight is by runtime upgrade.
@@ -155,34 +153,25 @@ parameter_types! { | |||
pub const BlockHashCount: BlockNumber = 2400; | |||
pub const SS58Prefix: u8 = 42; | |||
|
|||
pub ConfigurableBlockLength: limits::BlockLength = limits::BlockLength { max: PerDispatchClass::new(|_| ConfigBlock::block_length()) }; | |||
pub ConfigurableBlockWeight: limits::BlockWeights = limits::BlockWeights::simple_max(Weight::from_parts(ConfigBlock::block_weight(), u64::MAX)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed because the configurable block weight/length
doesn't work when running it with subxt because it relies on the metadata and this has no effect.
The only way is to change block length and block weight is by runtime upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpestana Can you have a look at the staking configuration in this file that I didn't make any weird change?
pub const SignedDepositByte: Balance = 1 * CENTS; | ||
pub const SignedDepositIncreaseFactor: Percent = Percent::from_percent(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about this offhand; how do you know which value to set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied it from the westend/polkadot runtime but @gpestana can you double check :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the details but overall looks good to me and great to move back to released crates!
…d-update-deps' into na-chore-staking-miner-playground-update-deps
This PR updates the dependencies in staking-miner-playground and most of it is just noise.
Review
runtime/src/lib.rs
carefully and the rest is not that important.