Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps in staking-miner-playground #773

Merged
merged 17 commits into from
Apr 5, 2024

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Jan 16, 2024

This PR updates the dependencies in staking-miner-playground and most of it is just noise.

Review runtime/src/lib.rs carefully and the rest is not that important.

@niklasad1 niklasad1 changed the title WIP: chore: update deps in staking-miner-playground chore: update deps in staking-miner-playground Jan 17, 2024
@niklasad1 niklasad1 marked this pull request as ready for review January 17, 2024 10:53
Copy link
Member Author

@niklasad1 niklasad1 Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed because the configurable block weight/length doesn't work when running it with subxt because it relies on the metadata and this has no effect.

The only way is to change block length and block weight is by runtime upgrade.

@@ -155,34 +153,25 @@ parameter_types! {
pub const BlockHashCount: BlockNumber = 2400;
pub const SS58Prefix: u8 = 42;

pub ConfigurableBlockLength: limits::BlockLength = limits::BlockLength { max: PerDispatchClass::new(|_| ConfigBlock::block_length()) };
pub ConfigurableBlockWeight: limits::BlockWeights = limits::BlockWeights::simple_max(Weight::from_parts(ConfigBlock::block_weight(), u64::MAX));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed because the configurable block weight/length doesn't work when running it with subxt because it relies on the metadata and this has no effect.

The only way is to change block length and block weight is by runtime upgrade.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpestana Can you have a look at the staking configuration in this file that I didn't make any weird change?

pub const SignedDepositByte: Balance = 1 * CENTS;
pub const SignedDepositIncreaseFactor: Percent = Percent::from_percent(10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about this offhand; how do you know which value to set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from the westend/polkadot runtime but @gpestana can you double check :)

Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the details but overall looks good to me and great to move back to released crates!

@niklasad1 niklasad1 requested a review from gpestana January 17, 2024 16:08
@niklasad1 niklasad1 merged commit d923f43 into main Apr 5, 2024
10 of 11 checks passed
@niklasad1 niklasad1 deleted the na-chore-staking-miner-playground-update-deps branch April 5, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants