ci: move nightly job to the CI.
#770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the binaries `polkadot` and `staking-miner-playground` are built in a cronjob, running all tests should take ~5 minutes which is fast enough for the CI.
niklasad1
force-pushed
the
ci-remove-nightly-job
branch
from
1068d97 to
ad40089
Compare
niklasad1
force-pushed
the
ci-remove-nightly-job
branch
from
ad40089 to
63977c6
Compare
niklasad1
commented
Jan 12, 2024
niklasad1
commented
Jan 12, 2024
| mkdir -p ~/.local/bin | ||
| mv ./tmp/polkadot* ~/.local/bin | ||
| mv ./tmp/staking-miner-playground ~/.local/bin | ||
| mkdir -p /usr/local/bin |
There was a problem hiding this comment.
I changed this path because it was not found in the default path, not sure how it worked before 🤔
niklasad1
commented
Jan 12, 2024
| @@ -29,6 +29,9 @@ jobs: | |||
| run: | | |||
| cargo build -p polkadot --release --features fast-runtime | |||
| ./target/release/polkadot --version | |||
| strip -s ./target/release/polkadot | |||
There was a problem hiding this comment.
strip binaries to make the download faster
niklasad1
commented
Jan 12, 2024
| @@ -34,6 +34,7 @@ jobs: | |||
| cd staking-miner-playground | |||
| cargo build --release --features test-trimming | |||
| ./target/release/staking-miner-playground --version | |||
| strip -s ./target/release/staking-miner-playground | |||
There was a problem hiding this comment.
strip binary to make the download faster, this is over 1GB unstripped.
niklasad1
commented
Jan 12, 2024
lexnv
approved these changes
Jan 16, 2024
tadeohepperle
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the binaries
polkadotandstaking-miner-playgroundare built in a cronjob, running all tests should take ~5-10 minutes which is fast enough for the CI.