CI improve nightly GHA workflow #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Jan 4, 2024
| with: | ||
| name: staking-miner-playground-binary | ||
| path: ./staking-miner-playground/target/release/staking-miner-playground | ||
| retention-days: 8 |
There was a problem hiding this comment.
I think you could increase retention-rate to something like 30 days because the staking-miner playground hasn't been changed for a long time.
There was a problem hiding this comment.
Ok. Let it be 31, and binary will be rebuild on 1st day of every month :)
niklasad1
reviewed
Jan 4, 2024
| branches: | ||
| - main | ||
| paths: | ||
| - 'staking-miner-playground/**' |
niklasad1
approved these changes
Jan 4, 2024
Yes. It's taking ~5 mins https://github.com/sergejparity/polkadot-staking-miner/actions/runs/7386921007 |
alvicsam
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
nightlyworkflow by movingPolkadotandStaking miner playgroundbinaries builds into separate workflows and just reusing its artifacts.Polkadotis rebuilt every day at 22:00Staking miner playgroundonce a month or when changes to its codebase is made.Both can be triggered manually if needed