Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate GitLab CI to GitHub Actions #729

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Migrate GitLab CI to GitHub Actions #729

merged 8 commits into from
Dec 18, 2023

Conversation

sergejparity
Copy link
Contributor

@sergejparity sergejparity commented Dec 14, 2023 •
edited
Loading

Migration of the GitLab CI to GitHub Actions in scope of https://github.com/paritytech/ci_cd/issues/841

  • This PR replaces GitLab CI with similar jobs executed via GitHub Actions
  • Updated Dockerfile to use ubuntu:22.04 instead of 20.04, because recently Docker image build started to fail with an error: Fixed
  • Moved hub.docker.com repository paritytech/staking-miner-v2 -> paritytech/polkadot-staking-miner

@niklasad1 maybe it worth to start using paritytech/polkadot-staking-miner on hub.docker.com instead of paritytech/staking-miner-v2?

!!! BEFORE MERGE
Setup repository secrets DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD

@sergejparity sergejparity requested a review from a team as a code owner December 14, 2023 10:34
@niklasad1
Copy link
Member

@niklasad1 maybe it worth to start using paritytech/polkadot-staking-miner on hub.docker.com instead of paritytech/staking-miner-v2?

Yes, please

@sergejparity
Copy link
Contributor Author

@niklasad1 maybe it worth to start using paritytech/polkadot-staking-miner on hub.docker.com instead of paritytech/staking-miner-v2?

Yes, please

Ok. Will arrange that.

niklasad1
niklasad1 reviewed Dec 14, 2023
View reviewed changes
.github/workflows/nightly.yml
sudo apt install -y protobuf-compiler
rustup target add wasm32-unknown-unknown
rustup component add rust-src
git clone -b master --depth 1 https://github.com/paritytech/polkadot-sdk.git polkadot-sdk
Copy link
Member

@niklasad1 niklasad1 Dec 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergejparity

Do think it would be easy to cache these binaries similar to what https://github.com/paritytech/subxt/blob/master/.github/workflows/build-substrate.yml does?

We might be able to enable this in the CI instead of running it every night then...

The staking-miner-playaround is rarely changed and it might be possible to cache and only rebuild it if the versions doesn't match...

alvicsam
alvicsam requested changes Dec 14, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
sergejparity and others added 2 commits December 14, 2023 14:05
@sergejparity @alvicsam
Update .github/workflows/ci.yml
017430c 
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@sergejparity
Merge main
14845fb
@alvicsam alvicsam self-requested a review December 14, 2023 13:26
niklasad1
niklasad1 reviewed Dec 14, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
niklasad1
niklasad1 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work

Just fix the failed job and it should be good to go.

@sergejparity
Copy link
Contributor Author

Slightly changed logic. Separated jobs for building Docker image. One just to test build during PR checks. And second to build and push image to registry from main branch or when v* tag applied.

@niklasad1
Copy link
Member

@sergejparity is this ready to merge?

I would want it in before publishing another release

@sergejparity sergejparity changed the title WIP Migrate GitLab CI to GitHub Actions Migrate GitLab CI to GitHub Actions Dec 18, 2023
@sergejparity
Copy link
Contributor Author

@sergejparity is this ready to merge?

I would want it in before publishing another release

Yes. It's ready to merge.

@sergejparity sergejparity merged commit 585194c into main Dec 18, 2023
11 checks passed
@sergejparity sergejparity mentioned this pull request Dec 18, 2023
Merged
@niklasad1 niklasad1 deleted the sk-migrate-gitlab-to-gha branch January 5, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergejparity @niklasad1 @alvicsam