use subxt-signer to reduce the number of deps
#720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #718 This commit reduces the dependency tree ~50 crates.
niklasad1
commented
Nov 29, 2023
niklasad1
commented
Nov 30, 2023
niklasad1
commented
Nov 30, 2023
niklasad1
commented
Nov 30, 2023
lexnv
approved these changes
Nov 30, 2023
niklasad1
added a commit
that referenced
this pull request
Dec 21, 2023
This reverts commit eb767d0.
niklasad1
added a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #718
This commit reduces the dependency tree ~50 crates by fixing that the repo doesn't bring in two versions of sp-core and sp-runtime.
The reason is that subxt has its own version of these crates when the
substrate-compatfeature flag is enabled and ideally we would remove bothsp-coreandsp-runtimecompletely but it doesn't work becausepallet-epmdepends on them.