Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Backport #7451 #7487

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link
Contributor

Backport #7451 into stable2412 from skunert.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7451-to-stable2412
git worktree add --checkout .worktree/backport-7451-to-stable2412 backport-7451-to-stable2412
cd .worktree/backport-7451-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

lexnv
lexnv previously approved these changes Feb 5, 2025
@skunert
Copy link
Contributor

skunert commented Feb 6, 2025

@EgorPopelyaev The others where not necessary after all, forgot about that. This one is ready 👍. No idea why the bot was reporting conflicts, I double checked and compiled locally 🤷‍♂️.

@skunert skunert marked this pull request as ready for review February 6, 2025 12:58
@EgorPopelyaev EgorPopelyaev merged commit 654b23e into stable2412 Feb 7, 2025
235 of 328 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7451-to-stable2412 branch February 7, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants