Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #6031 #6106

Open
wants to merge 1 commit into
base: stable2407
Choose a base branch
from

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6031 into stable2407 from drewstone.

See the documentation on how to use this bot.

# Description

I'm unable to build a bridge library due to the errors below, so I am
adding the explicit import to `sp_std::vec`.

## Integration

Projects using it can update their dependency. We are using the branch
`stable2407` (mixed them up in my branch).

## Errors
```
error: cannot find macro `vec` in this scope
  --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19
   |
99 |         let mut route = vec![];
   |                         ^^^
   |
help: consider importing one of these items
   |
23 + use scale_info::prelude::vec;
   |
23 + use sp_std::vec;
   |

error: cannot find macro `vec` in this scope
   --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36
    |
135 |         duplicate_votes_ancestries_idxs: vec![],
    |                                          ^^^
    |
help: consider importing one of these items
    |
19  + use scale_info::prelude::vec;
    |
19  + use sp_std::vec;
    |

error: cannot find macro `vec` in this scope
   --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21
    |
134 |         extra_precommits: vec![],
    |                           ^^^
    |
help: consider importing one of these items
    |
19  + use scale_info::prelude::vec;
    |
19  + use sp_std::vec;
    |

error: cannot find macro `vec` in this scope
  --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27
   |
89 |         let mut equivocations = vec![];
   |                                 ^^^
   |
help: consider importing one of these items
   |
19 + use scale_info::prelude::vec;
   |
19 + use sp_std::vec;
```

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
(cherry picked from commit 31dfc9f)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Oct 17, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 17, 2024 13:18
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7593405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants