Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pallet-revive] implement tx origin API #6105

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[pallet-revive] implement tx origin API #6105

wants to merge 6 commits into from
+571 −427

Conversation

xermicus
Copy link
Member

Implement a syscall to retreive the transaction origin.

@xermicus
[pallet-revive] implement tx origin API
09e8c47 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus
Copy link
Member Author

bot bench substrate-pallet --pallet=pallet_revive

@command-bot
Copy link

command-bot bot commented Oct 17, 2024 •
edited
Loading

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592845 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 16-5fff8fbf-fbc7-47db-a8b7-5c6accb5fb5d to cancel this command or bot cancel to cancel all commands in this pull request.

@xermicus xermicus added R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts. labels Oct 17, 2024
@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592845 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592845/artifacts/download.

@xermicus
Copy link
Member Author

/cmd prdoc --audience runtime_dev --bump minor

actions-user and others added 2 commits October 17, 2024 13:01
@actions-user
Update from xermicus running command 'prdoc --audience runtime_dev --…
5563391 
…bump minor'
@xermicus
typo
32e6095 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus
Copy link
Member Author

bot bench substrate-pallet --pallet=pallet_revive

@command-bot
Copy link

command-bot bot commented Oct 17, 2024 •
edited
Loading

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7593264 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 17-7e1f54f0-fca2-43fb-8c68-b710175c9a39 to cancel this command or bot cancel to cancel all commands in this pull request.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
a8c01be 
…=dev --target_dir=substrate --features=riscv --pallet=pallet_revive
@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7593264 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7593264/artifacts/download.

@xermicus
Copy link
Member Author

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 17, 2024 •
edited
Loading

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7594728 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 18-27f397af-0c16-4f37-a156-cd8aeb22e6a0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7594728 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7594728/artifacts/download.

xermicus
xermicus commented Oct 17, 2024
View reviewed changes
substrate/frame/revive/uapi/src/host.rs
@@ -206,6 +206,16 @@ pub trait HostFn: private::Sealed {
/// - `output`: A reference to the output data buffer to write the caller address.
fn caller(output: &mut [u8; 20]);

/// Stores the origin address (initator of the call stack) into the supplied buffer.
///
/// If there is no address associated with the origin (e.g. because the origin is root) then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does that happen? Should probably point it out here

@xermicus xermicus marked this pull request as ready for review October 17, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgherveou pgherveou Awaiting requested review from pgherveou

@athei athei Awaiting requested review from athei

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xermicus @actions-user