Import vec to bridges/primitives/header-chain #6031

drewstone · 2024-10-13T04:07:45Z

Description

I'm unable to build a bridge library due to the errors below, so I am adding the explicit import to sp_std::vec.

Integration

Projects using it can update their dependency. We are using the branch stable2407 (mixed them up in my branch).

Errors

error: cannot find macro `vec` in this scope
  --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19
   |
99 |         let mut route = vec![];
   |                         ^^^
   |
help: consider importing one of these items
   |
23 + use scale_info::prelude::vec;
   |
23 + use sp_std::vec;
   |

error: cannot find macro `vec` in this scope
   --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36
    |
135 |         duplicate_votes_ancestries_idxs: vec![],
    |                                          ^^^
    |
help: consider importing one of these items
    |
19  + use scale_info::prelude::vec;
    |
19  + use sp_std::vec;
    |

error: cannot find macro `vec` in this scope
   --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21
    |
134 |         extra_precommits: vec![],
    |                           ^^^
    |
help: consider importing one of these items
    |
19  + use scale_info::prelude::vec;
    |
19  + use sp_std::vec;
    |

error: cannot find macro `vec` in this scope
  --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27
   |
89 |         let mut equivocations = vec![];
   |                                 ^^^
   |
help: consider importing one of these items
   |
19 + use scale_info::prelude::vec;
   |
19 + use sp_std::vec;

bkchr · 2024-10-15T13:21:40Z

@drewstone please provide a prdoc.

bkchr · 2024-10-15T18:55:00Z

/cmd prdoc --audience node_dev --bump patch

github-actions · 2024-10-15T18:57:09Z

Command "prdoc --audience node_dev --bump patch" has failed ❌! See logs here

drewstone · 2024-10-15T19:00:35Z

@bkchr can you confirm I added the prdoc correctly?

bridges/primitives/header-chain/src/justification/verification/mod.rs

paritytech-cicd-pr · 2024-10-15T19:55:15Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7579181

bkchr · 2024-10-15T20:13:54Z

@drewstone can you merge master?

…/mod.rs

drewstone · 2024-10-16T22:04:13Z

Ah darn I had opened this against stable2407 cause we are pegged to that lol. We needed it in that branch foremost.

acatangiu · 2024-10-17T10:24:05Z

Ah darn I had opened this against stable2407 cause we are pegged to that lol. We needed it in that branch foremost.

That's fine, it will be backported to that branch once we merge it to master.

acatangiu · 2024-10-17T10:24:26Z

bot fmt

command-bot · 2024-10-17T10:24:32Z

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592101 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-2e7bcdbc-6bb4-4754-8995-fec87fb4a15c to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-10-17T10:26:53Z

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592101 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592101/artifacts/download.

# Description I'm unable to build a bridge library due to the errors below, so I am adding the explicit import to `sp_std::vec`. ## Integration Projects using it can update their dependency. We are using the branch `stable2407` (mixed them up in my branch). ## Errors ``` error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19 | 99 | let mut route = vec![]; | ^^^ | help: consider importing one of these items | 23 + use scale_info::prelude::vec; | 23 + use sp_std::vec; | error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36 | 135 | duplicate_votes_ancestries_idxs: vec![], | ^^^ | help: consider importing one of these items | 19 + use scale_info::prelude::vec; | 19 + use sp_std::vec; | error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21 | 134 | extra_precommits: vec![], | ^^^ | help: consider importing one of these items | 19 + use scale_info::prelude::vec; | 19 + use sp_std::vec; | error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27 | 89 | let mut equivocations = vec![]; | ^^^ | help: consider importing one of these items | 19 + use scale_info::prelude::vec; | 19 + use sp_std::vec; ``` --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit 31dfc9f)

paritytech-cmd-bot-polkadot-sdk · 2024-10-17T13:16:47Z

Successfully created backport PR for stable2407:

[stable2407] Backport #6031 #6106

# Description I'm unable to build a bridge library due to the errors below, so I am adding the explicit import to `sp_std::vec`. ## Integration Projects using it can update their dependency. We are using the branch `stable2407` (mixed them up in my branch). ## Errors ``` error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19 | 99 | let mut route = vec![]; | ^^^ | help: consider importing one of these items | 23 + use scale_info::prelude::vec; | 23 + use sp_std::vec; | error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36 | 135 | duplicate_votes_ancestries_idxs: vec![], | ^^^ | help: consider importing one of these items | 19 + use scale_info::prelude::vec; | 19 + use sp_std::vec; | error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21 | 134 | extra_precommits: vec![], | ^^^ | help: consider importing one of these items | 19 + use scale_info::prelude::vec; | 19 + use sp_std::vec; | error: cannot find macro `vec` in this scope --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27 | 89 | let mut equivocations = vec![]; | ^^^ | help: consider importing one of these items | 19 + use scale_info::prelude::vec; | 19 + use sp_std::vec; ``` --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit 31dfc9f)

paritytech-cmd-bot-polkadot-sdk · 2024-10-17T13:16:52Z

Successfully created backport PR for stable2409:

[stable2409] Backport #6031 #6107

paritytech-review-bot bot requested a review from a team October 13, 2024 04:08

drewstone changed the title ~~import vec/vec::Vec~~ Import vec to bridges/primitives/header-chain Oct 13, 2024

bkchr added the T15-bridges This PR/Issue is related to bridges. label Oct 15, 2024

bkchr previously approved these changes Oct 15, 2024

View reviewed changes

serban300 previously approved these changes Oct 15, 2024

View reviewed changes

drewstone dismissed stale reviews from serban300 and bkchr via ab13083 October 15, 2024 19:00

paritytech-review-bot bot requested a review from a team October 15, 2024 19:00

bkchr previously approved these changes Oct 15, 2024

View reviewed changes

bridges/primitives/header-chain/src/justification/verification/mod.rs Outdated Show resolved Hide resolved

bkchr dismissed their stale review via 7c0381b October 15, 2024 19:34

drewstone and others added 3 commits October 16, 2024 11:03

import vec/vec::Vec

0f3218f

Add prdoc

b9d931f

Update bridges/primitives/header-chain/src/justification/verification…

8896b95

…/mod.rs

bkchr force-pushed the drew/stable2047 branch from 7c0381b to 8896b95 Compare October 16, 2024 09:04

bkchr requested review from athei, acatangiu, sorpaas, cheme, a team and koute as code owners October 16, 2024 09:04

bkchr changed the base branch from stable2407 to master October 16, 2024 09:05

bkchr removed request for a team, koute, cheme, athei, sorpaas and acatangiu October 16, 2024 09:05

paritytech-review-bot bot requested a review from a team October 16, 2024 09:05

bkchr approved these changes Oct 16, 2024

View reviewed changes

bkchr added the A4-needs-backport Pull request must be backported to all maintained releases. label Oct 16, 2024

bkchr enabled auto-merge October 16, 2024 09:06

bkchr requested a review from serban300 October 16, 2024 09:06

bkontur approved these changes Oct 16, 2024

View reviewed changes

serban300 approved these changes Oct 16, 2024

View reviewed changes

Merge branch 'master' into drew/stable2047

d5d8fa1

".git/.scripts/commands/fmt/fmt.sh"

14cda0e

Merge branch 'master' into drew/stable2047

96fb0ee

bkchr added this pull request to the merge queue Oct 17, 2024

Merged via the queue into paritytech:master with commit 31dfc9f Oct 17, 2024
190 of 193 checks passed

paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Oct 17, 2024

[stable2407] Backport #6031 #6106

Open

paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Oct 17, 2024

[stable2409] Backport #6031 #6107

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import vec to bridges/primitives/header-chain #6031

Import vec to bridges/primitives/header-chain #6031

drewstone commented Oct 13, 2024 •

edited

Loading

bkchr commented Oct 15, 2024

bkchr commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

drewstone commented Oct 15, 2024

paritytech-cicd-pr commented Oct 15, 2024

bkchr commented Oct 15, 2024

drewstone commented Oct 16, 2024 •

edited

Loading

acatangiu commented Oct 17, 2024

acatangiu commented Oct 17, 2024

command-bot bot commented Oct 17, 2024 •

edited

Loading

command-bot bot commented Oct 17, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Oct 17, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Oct 17, 2024

Import vec to bridges/primitives/header-chain #6031

Import vec to bridges/primitives/header-chain #6031

Conversation

drewstone commented Oct 13, 2024 • edited Loading

Description

Integration

Errors

bkchr commented Oct 15, 2024

bkchr commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

drewstone commented Oct 15, 2024

paritytech-cicd-pr commented Oct 15, 2024

bkchr commented Oct 15, 2024

drewstone commented Oct 16, 2024 • edited Loading

acatangiu commented Oct 17, 2024

acatangiu commented Oct 17, 2024

command-bot bot commented Oct 17, 2024 • edited Loading

command-bot bot commented Oct 17, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Oct 17, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Oct 17, 2024

drewstone commented Oct 13, 2024 •

edited

Loading

drewstone commented Oct 16, 2024 •

edited

Loading

command-bot bot commented Oct 17, 2024 •

edited

Loading