[pallet-revive] Add Ethereum JSON-RPC server #5953
Conversation
pgherveou
force-pushed
the
pg/revive-rpc-server
branch
5 times, most recently
from
d80a5ce
to
d931a80
Compare
Depends on #5866
pgherveou
force-pushed
the
pg/revive-rpc-server
branch
from
ebb0b36
to
de0b0ef
Compare
pgherveou
added
R0-silent
There was a problem hiding this comment.
Should have a better name than just "demo". Maybe "rpc_demo".
| #[subxt::subxt( | ||
| runtime_metadata_path = "kitchensink.scale", | ||
| substitute_type( | ||
| path = "pallet_revive::primitives::EthContractResult<A>", | ||
| with = "::subxt::utils::Static<::pallet_revive::EthContractResult<A>>" | ||
| ), | ||
| substitute_type( | ||
| path = "pallet_revive::primitives::EthTransactKind", | ||
| with = "::subxt::utils::Static<::pallet_revive::EthTransactKind>" | ||
| ), | ||
| substitute_type( | ||
| path = "sp_weights::weight_v2::Weight", | ||
| with = "::subxt::utils::Static<::sp_weights::Weight>" | ||
| ) | ||
| )] |
There was a problem hiding this comment.
I think we need to use the dynamic API of subxt here. Otherwise the pallet ids and so on will be hardcoded to whatever kitchensink is using, right?
Or how do we make sure that this will be compatible across different runtimes (westend ah, kusama ah, polkadot ah)?
There was a problem hiding this comment.
Yes correct, the only thing that can break I believe is the encoding of the dispatchable, since the index will differ for each runtime, I was planning to go with feature flag to start with, until I find a more suitable solution, will look into their dynamic API as well.
| pub extern "C" fn call() { | ||
| input!(128, data: [u8],); | ||
| api::deposit_event(&[], data); |
There was a problem hiding this comment.
Can we assert the selector here? ether.js should derive a selector from the provided ABI.
There was a problem hiding this comment.
ah right yes it does, might be easier to add the assert in the js code directly, since that's where we define the "fake ABI"
No description provided.