Refactor get_account_id_from_seed / get_from_seed to one common place #5804
+536
−892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
iulianbarbu
reviewed
Oct 1, 2024
There was a problem hiding this comment.
There are usages of get_account_id_from_seed in templates/parachain/runtime/src/genesis_config_presets.rs, can you update this too?
Not sure what IDE you're using, but if it is using rust-analyzer it might see the errors there if you set WASM_BUILD_CARGO_ARGS="--message-format=json" in the environment before starting your IDE and waiting for a full build/indexing. Also, please mark this PR as ready for review as soon as you changed everything you wanted (merging it with latest master might be a good thing to do before then too).
programskillforverification
requested review from
michalkucharczyk and
iulianbarbu
iulianbarbu
reviewed
Oct 8, 2024
cumulus/parachains/integration-tests/emulated/common/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
programskillforverification
force-pushed
the
refactor-get_account_id_from_seed
branch
from
5cb994d
to
a161d07
Compare
iulianbarbu
reviewed
Oct 16, 2024
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml
Outdated
Show resolved
Hide resolved
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
michalkucharczyk
approved these changes
Oct 16, 2024
|
I'd wait for @davxy opinion as this PR touches |
programskillforverification
force-pushed
the
refactor-get_account_id_from_seed
branch
from
225df75
to
c7b31af
Compare
davxy
approved these changes
Oct 16, 2024
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
davxy
requested changes
Oct 17, 2024
programskillforverification
force-pushed
the
refactor-get_account_id_from_seed
branch
from
87ce254
to
341c689
Compare
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
davxy
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5705