-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AHs] Support registering assets on Asset Hubs over bridge #5435
[AHs] Support registering assets on Asset Hubs over bridge #5435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…ster-assets-over-bridge
impl<AssetsAllowedNetworks: Contains<Location>, OriginLocation: Get<Location>> | ||
ContainsPair<Asset, Location> for RemoteAssetFromLocation<AssetsAllowedNetworks, OriginLocation> | ||
impl< | ||
L: TryInto<Location> + Clone, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe xcm::TryAs
would also work here:
L: TryInto<Location> + Clone, | |
L: TryAs<Location>, |
so we don't need to clone anything here:
let Ok(asset) = asset.try_as() else {
return false;
};
let Ok(origin) = origin.try_as() else {
return false;
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the trait TryAs<cumulus_primitives_core::Location>
is not implemented for cumulus_primitives_core::Location
, which is required by `RemoteAssetFromLocation<AssetsAllowedNetworks, OriginLocation>: ContainsPair<cumulus_primitives_core::Location, cumulus_primitives_core::Location>
although it should work...
9714796
Changes
Allows one Asset Hub on one side, to register assets on the other Asset Hub over the bridge.
Rococo <> Ethereum test bridge will be dropped in favor of Westend <> Ethereum test bridge. This PR also changes emulated tests to simulate double bridging from Ethereum<>Westend<>Rococo.
Tests