You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If it is going to be part of the PR, I suggest either not creating a new issue that is going to be immediately closed, or please semantically link this issue to 5804 so that it will get closed when the PR is merged.
If it is going to be part of the PR, I suggest either not creating a new issue that is going to be immediately closed, or please semantically link this issue to 5804 so that it will get closed when the PR is merged.
I see. Now, maybe I plan to create new PR due to effect too many files.
Is there an existing issue?
Experiencing problems? Have you tried our Stack Exchange first?
Motivation
https://github.com/paritytech/polkadot-sdk/blob/master/substrate/primitives/keyring/src/lib.rs#L34
Compared with
AccountKeyring
,Sr25519Keyring
andEd25519Keyring
are more intuitive.When both
Sr25519Keyring
andEd25519Keyring
are required, usingAccountKeyring
bring confusion. There are twoAccountKeyring
definitions, it becomes more complex if export twoAccountKeyring
from frame.Request
remove all
AccountKeyring
, re-exportSr25519Keyring
andEd25519Keyring
fromframe
so that don't need extra usesp-keyring
Solution
No response
Are you willing to help with this request?
Yes!
The text was updated successfully, but these errors were encountered: