Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatxpool: improve handling of limits in submit_and_watch. #5494

Closed
Tracked by #5472
michalkucharczyk opened this issue Aug 27, 2024 · 1 comment
Closed
Tracked by #5472

fatxpool: improve handling of limits in submit_and_watch. #5494

michalkucharczyk opened this issue Aug 27, 2024 · 1 comment
Assignees
@michalkucharczyk
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@michalkucharczyk
Copy link
Contributor

michalkucharczyk commented Aug 27, 2024 •
edited
Loading

When handling limits, submit_and_watch shall follow the logic implemented for submit. Currently limits are not checked during submission (with submit_and_watch), however they work in most cases due to eventing system which handles dropped transactions correctly.

Some improvements in handling limits in submit may also be implemented.
@michalkucharczyk michalkucharczyk self-assigned this Aug 27, 2024
@michalkucharczyk michalkucharczyk added the T0-node This PR/Issue is related to the topic “node”. label Aug 27, 2024
@michalkucharczyk michalkucharczyk mentioned this issue Aug 27, 2024
Open
@michalkucharczyk michalkucharczyk changed the title fatxpool: Improve handling of limits in submit_and_watch. fatxpool: improve handling of limits in submit_and_watch. Aug 27, 2024
@michalkucharczyk michalkucharczyk mentioned this issue Aug 27, 2024
Merged
@michalkucharczyk
Copy link
Contributor Author

michalkucharczyk commented Sep 27, 2024 •
edited
Loading

should be done here: 1f4f74b
Some tests will follow in #5478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalkucharczyk michalkucharczyk

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michalkucharczyk