Skip to content

Commit

Permalink
fmt and feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
  • Loading branch information
sandreim committed Oct 17, 2024
1 parent 4b2c06f commit 320318a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 14 deletions.
4 changes: 2 additions & 2 deletions polkadot/node/core/approval-voting/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ use polkadot_node_subsystem_util::{
use polkadot_primitives::{
vstaging::CandidateReceiptV2 as CandidateReceipt, ApprovalVoteMultipleCandidates,
ApprovalVotingParams, BlockNumber, CandidateHash, CandidateIndex, CoreIndex, ExecutorParams,
GroupIndex, Hash, SessionIndex, SessionInfo, ValidatorId, ValidatorIndex,
ValidatorPair, ValidatorSignature,
GroupIndex, Hash, SessionIndex, SessionInfo, ValidatorId, ValidatorIndex, ValidatorPair,
ValidatorSignature,
};
use sc_keystore::LocalKeystore;
use sp_application_crypto::Pair;
Expand Down
4 changes: 2 additions & 2 deletions polkadot/node/core/backing/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ use polkadot_primitives::{
CommittedCandidateReceiptV2 as CommittedCandidateReceipt, CoreState,
},
CandidateCommitments, CandidateHash, CoreIndex, ExecutorParams, GroupIndex, GroupRotationInfo,
Hash, Id as ParaId, IndexedVec, NodeFeatures, PersistedValidationData,
SessionIndex, SigningContext, ValidationCode, ValidatorId, ValidatorIndex, ValidatorSignature,
Hash, Id as ParaId, IndexedVec, NodeFeatures, PersistedValidationData, SessionIndex,
SigningContext, ValidationCode, ValidatorId, ValidatorIndex, ValidatorSignature,
ValidityAttestation,
};
use polkadot_statement_table::{
Expand Down
4 changes: 2 additions & 2 deletions polkadot/node/core/candidate-validation/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ use polkadot_primitives::{
CandidateReceiptV2 as CandidateReceipt,
},
AuthorityDiscoveryId, CandidateCommitments, ExecutorParams, Hash, OccupiedCoreAssumption,

Check failure on line 52 in polkadot/node/core/candidate-validation/src/lib.rs

View workflow job for this annotation

GitHub Actions / cargo-check-all-crate-macos

unused import: `OccupiedCoreAssumption`
PersistedValidationData, PvfExecKind as RuntimePvfExecKind, PvfPrepKind, SessionIndex, ValidationCode,
ValidationCodeHash, ValidatorId,
PersistedValidationData, PvfExecKind as RuntimePvfExecKind, PvfPrepKind, SessionIndex,
ValidationCode, ValidationCodeHash, ValidatorId,
};
use sp_application_crypto::{AppCrypto, ByteArray};
use sp_keystore::KeystorePtr;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ pub struct FetchedCollation {
pub para_id: ParaId,
/// Candidate hash.
pub candidate_hash: CandidateHash,
/// Id of the collator the collation was fetched from.
/// This will be missing when we create the struct from
/// a v2 candidate receipt. instance
pub collator_id: Option<CollatorId>,
}

impl From<&CandidateReceipt<Hash>> for FetchedCollation {
Expand All @@ -84,7 +80,6 @@ impl From<&CandidateReceipt<Hash>> for FetchedCollation {
relay_parent: descriptor.relay_parent(),
para_id: descriptor.para_id(),
candidate_hash: receipt.hash(),
collator_id: descriptor.collator(),
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions polkadot/node/subsystem-types/src/messages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ use polkadot_primitives::{
CandidateIndex, CollatorId, CoreIndex, DisputeState, ExecutorParams, GroupIndex,
GroupRotationInfo, Hash, HeadData, Header as BlockHeader, Id as ParaId, InboundDownwardMessage,
InboundHrmpMessage, MultiDisputeStatementSet, NodeFeatures, OccupiedCoreAssumption,
PersistedValidationData, PvfCheckStatement, PvfExecKind as RuntimePvfExecKind, SessionIndex, SessionInfo,
SignedAvailabilityBitfield, SignedAvailabilityBitfields, ValidationCode, ValidationCodeHash,
ValidatorId, ValidatorIndex, ValidatorSignature,
PersistedValidationData, PvfCheckStatement, PvfExecKind as RuntimePvfExecKind, SessionIndex,
SessionInfo, SignedAvailabilityBitfield, SignedAvailabilityBitfields, ValidationCode,
ValidationCodeHash, ValidatorId, ValidatorIndex, ValidatorSignature,
};
use polkadot_statement_table::v2::Misbehavior;
use std::{
Expand Down

0 comments on commit 320318a

Please sign in to comment.