FIX add hyperlink to log when submission failed #576
Conversation
| # check that we have a link to the log of the failed submission | ||
| print(leaderboard_failed) | ||
| assert False | ||
| assert "<a href=" in leaderboard_failed |
There was a problem hiding this comment.
OK so the string is:
<a href=/abcb5aeab7e78cd43636a10d6856dcdf4ae886c6/error.txt>
So we can make a regex <a href=/*/error.txt>
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 103 103
Lines 8962 8964 +2
=======================================
+ Hits 8382 8384 +2
Misses 580 580
Continue to review full report at Codecov.
|
|
Thx @glemaitre I suggest we make a minor release and update the server ok? |
I would like to tackle this one before that: |
|
@glemaitre @frcaud I'll tag the 0.10.1 release with this fix and deploy this if you don't mind. I haven't realized it wasn't deployed, and it's a regression. cc @jjerphan |
|
Fine with me. |
* FIX add hyperlink to log when submission failed * debug * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py * Update test_leaderboard.py * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py
|
LGTM ! |
closes #575
I suspect this is the source of the error that was introduced in #366
We should probably add a non-regression test that checks that we have a link to a hyperlink with the
failedleaderboard.