FIX add hyperlink to log when submission failed (#576)

* FIX add hyperlink to log when submission failed * debug * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py * Update test_leaderboard.py * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py * Update ramp-database/ramp_database/tools/tests/test_leaderboard.py
paris-saclay-cds · May 22, 2022 · ccf2cf5 · ccf2cf5
1 parent 9d2f479
commit ccf2cf5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/ramp-database/ramp_database/tools/leaderboard.py b/ramp-database/ramp_database/tools/leaderboard.py
@@ -429,7 +429,7 @@ def get_leaderboard(
                 "submission",
                 "submitted at (UTC)",
                 "state",
-                "wating list",
+                "waiting list",
             ]
         else:
             columns = ["team", "submission", "submitted at (UTC)", "error"]
@@ -447,7 +447,7 @@ def get_leaderboard(
                         pd.Timestamp(sub.submission_timestamp),
                         (
                             sub.state_with_link
-                            if leaderboard_type == "error"
+                            if leaderboard_type == "failed"
                             else sub.state
                         ),
                         (

diff --git a/ramp-database/ramp_database/tools/tests/test_leaderboard.py b/ramp-database/ramp_database/tools/tests/test_leaderboard.py
@@ -1,3 +1,4 @@
+import re
 import shutil
 
 import pytest
@@ -170,6 +171,8 @@ def test_get_leaderboard(session_toy_db):
         session_toy_db, "failed", "iris_test", "test_user"
     )
     assert leaderboard_failed.count("<tr>") == 1
+    # check that we have a link to the log of the failed submission
+    assert re.match(r".*<a href=/.*/error.txt>.*", leaderboard_failed, flags=re.DOTALL)
 
     # the remaining submission should be successful
     leaderboard_public = get_leaderboard(session_toy_db, "public", "iris_test")