Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e_tests: Add logging tests #771

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

gowthamsk-arm
Copy link
Contributor

This test case covers mitigation 3 of the threat model.
https://parallaxsecond.github.io/parsec-book/parsec_security/parsec_threat_model/threat_model.html

It's ignored by default so that local testing is unaffected by it. On the CI we explicity run the test after diverting the parsec service logs to a log file.

Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com

Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small question, otherwise looks good to me :)

e2e_tests/tests/all_providers/logging.rs Show resolved Hide resolved
Copy link
Collaborator

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ( Can we check if the test is a false positive? )

This test case covers mitigation 3 of the threat model.
https://parallaxsecond.github.io/parsec-book/parsec_security/parsec_threat_model/threat_model.html

It's ignored by default so that local testing is unaffected by it.
On the CI we explicity run the test after diverting the parsec
service logs to a log file.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Copy link
Collaborator

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gowthamsk-arm
Copy link
Contributor Author

The issue we see on the CI is related to compilation of a dependency crate using a nightly rust compiler nothing related to the test that I added.
This has been reported by other users as well here

@gowthamsk-arm gowthamsk-arm merged commit 722a7ba into parallaxsecond:main Jun 27, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants