-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e_tests: Add logging tests #771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small question, otherwise looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ( Can we check if the test is a false positive? )
This test case covers mitigation 3 of the threat model. https://parallaxsecond.github.io/parsec-book/parsec_security/parsec_threat_model/threat_model.html It's ignored by default so that local testing is unaffected by it. On the CI we explicity run the test after diverting the parsec service logs to a log file. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The issue we see on the CI is related to compilation of a dependency crate using a nightly rust compiler nothing related to the test that I added. |
This test case covers mitigation 3 of the threat model.
https://parallaxsecond.github.io/parsec-book/parsec_security/parsec_threat_model/threat_model.html
It's ignored by default so that local testing is unaffected by it. On the CI we explicity run the test after diverting the parsec service logs to a log file.
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com