Skip to content

Commit

Permalink
Clean up psalm-suppress statements
Browse files Browse the repository at this point in the history
  • Loading branch information
paragonie-security committed Apr 19, 2024
1 parent 41edbb0 commit 9575244
Show file tree
Hide file tree
Showing 21 changed files with 909 additions and 996 deletions.
633 changes: 421 additions & 212 deletions lib/php72compat.php

Large diffs are not rendered by default.

207 changes: 136 additions & 71 deletions lib/sodium_compat.php

Large diffs are not rendered by default.

41 changes: 0 additions & 41 deletions psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,51 +7,10 @@
<directory name="lib" />
</projectFiles>
<issueHandlers>
<InvalidFunctionCall errorLevel="suppress" />
<!--
Previous issue type is suppressed because we have to use a string
as a function name for PHP 5.2 compatibility. When testing, be sure
to change this to "info".
-->

<UndefinedFunction errorLevel="info" />
<!--
Inconsistently erroneous.
-->

<DuplicateClass errorLevel="info" />
<!--
Psalm isn't correctly identifying the guard conditions that return
early if a class already exists.
-->
<RedundantConditionGivenDocblockType errorLevel="suppress" />

<TooFewArguments errorLevel="info" />

<DocblockTypeContradiction errorLevel="suppress" />
<RedundantCondition errorLevel="info" />
<!--
Redundancy is good for PHP <7
-->

<TypeDoesNotContainType errorLevel="info" />
<!--
This mostly fails on `PHP_INT_SIZE === 4`
-->

<InternalMethod errorLevel="suppress" />
<!--
We mark methods as internal.
-->
<PossiblyNullArgument errorLevel="suppress" />
<!--
Not interesting
-->

<RedundantCast errorLevel="info" />
<UnnecessaryVarAnnotation errorLevel="suppress" />
<UnusedVariable errorLevel="info" />
<UnusedFunctionCall errorLevel="info" />

</issueHandlers>
</psalm>
Loading

0 comments on commit 9575244

Please sign in to comment.