Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

fix: set max fee per gas correctly #152

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: set max fee per gas correctly #152

merged 1 commit into from
Oct 11, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Oct 11, 2024

The description for LoadFee::eip1559_fees is misleading, it does not return max_fee_per_gas and max_priority_fee_per_gas, it returns base_fee and max_priority_fee_per_gas.

Will fix this upstream as well.

@onbjerg onbjerg added the C-bug An unexpected or incorrect behavior label Oct 11, 2024
jenpaff
jenpaff approved these changes Oct 11, 2024
View reviewed changes
Copy link

@jenpaff jenpaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Rjected
Rjected approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@Rjected Rjected merged commit e1ca629 into main Oct 11, 2024
13 checks passed
@onbjerg onbjerg deleted the onbjerg/fee-fix branch October 11, 2024 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rjected Rjected Rjected approved these changes

@jenpaff jenpaff jenpaff approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onbjerg @jenpaff @Rjected