Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add full example for s3 log source #24

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

markosfount
Copy link
Collaborator

@markosfount markosfount commented Sep 18, 2024

Background

This is a small enhancement as part of "reviving" the Panther terraform provider, in order to be able to better test the provider during development. It is inspired from providers such as the aws terraform provider, who include some "runnable" examples of creating resources using their provider,

Changes

The changes here introduce a more complete example of how the terraform code for creating an S3 resource would look like, as well as instructions of how to run the example with using the provider code in this repo, rather than the published provider code.

This is useful when developing the provider, as one can build the provider and deploy a resource in their dev environment and test and verify how the log source looks and behaves. It is meant to compliment the existing tests.

It can be also useful for customers who clone the repo to see how using the provider would look in a more complete setup, with creating a resource, having input variables, outputs etc.

Testing

This is not changing any code for the provider as it is only an example. It has been tested by following the instructions in the README and running relevant terraform commands to verify that creating the resource:

terraform plan -var-file="test-vars.tfvars"
terraform apply -var-file="test-vars.tfvars"
terraform destroy -var-file="test-vars.tfvars"

@markosfount markosfount marked this pull request as ready for review September 18, 2024 10:09
@markosfount markosfount merged commit d6fecdf into main Oct 3, 2024
1 check passed
@markosfount markosfount deleted the mf-update-provider branch October 3, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants