fix stop/start

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016 SoftwareJoint - Erlang, XMPP, Ejabberd & Servers
+Copyright (c) 2016-2020 SoftwareJoint - Erlang, XMPP, Ejabberd & Servers
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

src/fcm.erl

@@ -1,5 +1,7 @@
 -module(fcm).
 
+-author('pankajsoni19@live.com').
+
 -behaviour(gen_server).
 
 -include("logger.hrl").
@@ -25,7 +27,7 @@ start_pool_with_json_service_file(Name, FilePath) ->
 
 -spec stop(atom()) -> ok.
 stop(Name) ->
-    gen_server:stop(Name, normal, 5000).
+    gen_server:call(Name, stop).
 
 -spec push(
             atom(),
@@ -68,6 +70,8 @@ handle_call({send, RegIds, Message, _Retry}, _From, State0) ->
     {ok, Reply, State} = fcm_api_v1:push(RegIds, Message, State0),
     {reply, Reply, State};
 
+handle_call(stop, _From, State) ->
+    {stop, normal, stopped, State};
 handle_call(_Request, _From, State) ->
     {reply, ok, State}.
 

src/fcm_api_v1.erl

@@ -1,5 +1,7 @@
 -module(fcm_api_v1).
 
+-author('pankajsoni19@live.com').
+
 -include("logger.hrl").
 
 -export([push/3]).

src/fcm_app.erl

@@ -1,5 +1,7 @@
 -module(fcm_app).
 
+-author('pankajsoni19@live.com').
+
 -behaviour(application).
 
 -export([start/2, stop/1]).

src/fcm_sup.erl

@@ -1,21 +1,30 @@
 -module(fcm_sup).
+
+-author('pankajsoni19@live.com').
+
 -behaviour(supervisor).
 
--export([start_link/0, start_child/2]).
+%% supervisor init
+-export([start_link/0]).
 
+%% supervisor callbacks
 -export([init/1]).
 
+%% function exports
+-export([start_child/2]).
+
 -define(CHILD(I, Type), {I, {I, start_link, []}, transient, 5000, Type, [I]}).
 
 -spec start_link() -> {ok, pid()}.
 start_link() ->
     supervisor:start_link({local, ?MODULE}, ?MODULE, []).
 
+%% supervisor callbacks
+-spec init([]) -> {ok, {{supervisor:strategy(), 5, 10}, [supervisor:child_spec()]}}.
+init([]) ->
+    {ok, {{simple_one_for_one, 5, 10}, [?CHILD(fcm, worker)]}}.
+
 -spec start_child(atom(), map()) ->
        {'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}.
 start_child(Name, Opts) ->
     supervisor:start_child(?MODULE, [Name, Opts]).
-
--spec init([]) -> {ok, {{supervisor:strategy(), 5, 10}, [supervisor:child_spec()]}}.
-init([]) ->
-    {ok, {{simple_one_for_one, 5, 10}, [?CHILD(fcm, worker)]}}.