Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use pipx and build to simplify and remove a workaround (2) #45611

Closed
wants to merge 3 commits into from

Conversation

henryiii
Copy link

@henryiii henryiii commented Jan 25, 2022

  • CI: use pipx and build to simplify and remove a workaround

  • ci: drop setup-python, show build version

  • closes #xxxx

  • tests added / passed

  • Ensure all linting tests pass, see here for how to run them

  • whatsnew entry

This cleans up the SDist build slightly. First, it uses PyPA's "build" instead of directly calling setup.py, which will respect PEP 518 requirements and avoids the workaround of installing NumPy to be able to run setup.py. It also uses pipx to avoid needless setup; PyPA's pipx is provides as a first-class package manager on GitHub Actions (and Azure, they share images).

Repushing #43157. No changes (except rebasing). I think the next step was to make sure the local SDist builds were brought in sync with this.

@jbrockmendel jbrockmendel added the CI Continuous Integration label Feb 11, 2022
@lithomas1 lithomas1 added this to the 1.4.2 milestone Feb 17, 2022
@lithomas1 lithomas1 requested a review from jreback February 18, 2022 02:04
@simonjayhawkins
Copy link
Member

I think the next step was to make sure the local SDist builds were brought in sync with this.

probably should do that before making the changes to the ci here in pandas which is just to catch problems early.

@lithomas1 lithomas1 added the Build Library building on various platforms label Feb 27, 2022
@simonjayhawkins
Copy link
Member

Thanks @henryiii for the PR. will close this to clear the queue.

As mentioned above and #43157 (comment), the sdist build on ci should replicate the release process to catch issues early so any changes should probably be made to https://github.com/pandas-dev/pandas-release in the first instance.

Given that there is active discussion on using cibuildwheel and pandas could soon be migrating #44027 (comment), I think I am happier not to make any changes to the release process for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants