Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paginate_rows() method #1269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jwodder
Copy link

@jwodder jwodder commented Oct 14, 2023

This PR adds a paginate_rows() method to the extension object that behaves like paginate(), except its items are sqlalchemy.Row instances instead of whatever was the in the first column of the select(). This makes it possible to paginate compound selects without having to fall back to the legacy Query API.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@HitkoDev
Copy link

Would love to see this merged, but it seems to be blocked by a merge conflict for now. @jwodder could you look into this so we can get maintainers to consider merging this?

@jwodder
Copy link
Author

jwodder commented Feb 26, 2025

I have rebased to remove the merge conflicts. The failing tests are in code that was already failing on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support select(Model.column1, Model.column2) in pagination
2 participants