Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc-macro2 version update- has other dependencies version updates #117

Closed
wants to merge 3 commits into from

Conversation

vsirivol
Copy link
Contributor

@vsirivol vsirivol commented Nov 1, 2024

Dependencies version updates to address: #116

@vsirivol vsirivol changed the title proc-macro2 version update- has other packages updates proc-macro2 version update- has other dependencies version updates Nov 1, 2024
@palfrey
Copy link
Owner

palfrey commented Nov 1, 2024

Given this doesn't actually change any part of the Cargo.toml only the lock file, I'm not entirely seeing the usefulness of this PR given only the former feed into the actual published crate.

Now, what would be of interest is a new build step like the "minimal versions" one, but starting with a cargo update to confirm we're still compatible with the bleeding edge of our listed dependencies i.e so people can do things like this update in their builds and show it'll still work fine, given we already do a monthly build check.

@vsirivol
Copy link
Contributor Author

vsirivol commented Nov 1, 2024

Given this doesn't actually change any part of the Cargo.toml only the lock file, I'm not entirely seeing the usefulness of this PR given only the former feed into the actual published crate.

Now, what would be of interest is a new build step like the "minimal versions" one, but starting with a cargo update to confirm we're still compatible with the bleeding edge of our listed dependencies i.e so people can do things like this update in their builds and show it'll still work fine, given we already do a monthly build check.

I have added a workflow step to update the packages.

@palfrey
Copy link
Owner

palfrey commented Nov 2, 2024

Thanks. So I ended up also wanting some build steps (and to run on stable), and then also realising that the env_logger requirements could be reduced, etc, etc. #118 builds on this and adds the extra bits I wanted for this which was a better path than trying to micromanage this with the features I wanted :)

@palfrey palfrey closed this Nov 2, 2024
@vsirivol
Copy link
Contributor Author

vsirivol commented Nov 2, 2024

Thanks for adding that. I am not sure if I am missing something but Cargo.lock file is not updated with the latest versions. Addressed the changes needed #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants