fix: Path params are ordered based on the path template, not endpoint definition #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoylan
commented
Mar 28, 2025
cycles/testdata/cycle-within-pkg/conjure/com/palantir/services/services.conjure.go
Outdated
Show resolved
Hide resolved
nmiyake
reviewed
Apr 14, 2025
nmiyake
approved these changes
Apr 14, 2025
|
Released v6.66.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
astForEndpointMethodBodyRequestParamswould create thehttpclient.WithPathfparameter using the argument ordering present in the conjure definition/intermediate representation. This is incorrect. Instead, the path parameters must match their ordering in the endpoint's http path template.We are NOT changing the argument ordering in the generated go interfaces, since it would be a (potentially silent) break and arguments are referenced by name, not position.
This change is