-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor Alert from a class to functional component #7184
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
chore: Refactor Alert from a class to functional componentBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
2d2d236
to
bdef9c0
Compare
Use mount in test to trigger warningsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
} = props; | ||
|
||
React.useEffect(() => { | ||
if (onClose == null && (cancelButtonText == null) !== (onCancel == null)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on spinner changes: https://github.com/palantir/blueprint/pull/7181/files#r1920669985
Part of #6289
Changes:
Refactors
Alert
from a class-based to functional component. All functionality should remain preserved.Example: Before / After