[core] fix(NumericInput): improve performance on Firefox (#5466) #7178
+35
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5466
Checklist
Changes proposed in this pull request:
Number.prototype.toLocaleString
is relatively slow on Firefox, and is currently heavily used byNumericInput.getDerivedStateFromProps
(which further callsisFloatingPointNumericCharacter
on each character of the current value). This means that if you have a bunch ofNumericInput
s on a form, it slows renders down to a crawl even if theNumericInput
isn't being updated itself.This PR improves the situation in two ways:
isFloatingPointNumericCharacter
per locale. I don't think there's a reasonable situation where the representation of numbers would change during page load.roundAndClampValue
when necessary ingetDerivedStateFromProps
- essentially, moves the computation ofsanitizedValue
within the if statement it's used in.You can see the difference in this Codepen (try using Firefox): https://codesandbox.io/p/devbox/condescending-vaughan-qysyk7
Reviewers should focus on:
Whether this changes behavior in any way.
I'm not sure whether
Map
is in the current "browser support level" of Blueprint, but its only use in the repo isuniqueId
whichNumericInput
also uses, so I assumed it's fine.