fix(eslint-config): Remove eslint-plugin-header patch (#7305)

palantir · Mar 3, 2025 · d320e1a · d320e1a · svc-palantir-github · Mar 3, 2025
1 parent 5dbd8b5
commit d320e1a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 26 deletions.
diff --git a/.yarn/patches/eslint-plugin-header-npm-3.1.1-402265ec6f.patch b/.yarn/patches/eslint-plugin-header-npm-3.1.1-402265ec6f.patch
diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js
@@ -25,6 +25,10 @@ const eslintBuiltinRules = require("./eslint-builtin-rules.js");
 const eslintPluginRules = require("./eslint-plugin-rules.js");
 const tsEslintRules = require("./typescript-eslint-rules.js");
 
+// ESLint 9 requires all rules with options to have a schema, but
+// eslint-plugin-header doesn't do this yet...
+headerPlugin.rules.header.meta.schema = false;
+
 module.exports = tseslint.config(
     blueprintPlugin.flatConfigs.recommended,
     importPlugin.flatConfigs.typescript,

diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -5,7 +5,7 @@
     "dependencies": {
         "@blueprintjs/eslint-plugin": "workspace:^",
         "eslint": "^9.20.0",
-        "eslint-plugin-header": "patch:eslint-plugin-header@npm%3A3.1.1#~/.yarn/patches/eslint-plugin-header-npm-3.1.1-402265ec6f.patch",
+        "eslint-plugin-header": "^3.1.1",
         "eslint-plugin-import": "~2.31.0",
         "eslint-plugin-jsdoc": "^48.0.2",
         "eslint-plugin-react": "^7.37.4",

diff --git a/yarn.lock b/yarn.lock
@@ -672,7 +672,7 @@ __metadata:
   dependencies:
     "@blueprintjs/eslint-plugin": "workspace:^"
     eslint: "npm:^9.20.0"
-    eslint-plugin-header: "patch:eslint-plugin-header@npm%3A3.1.1#~/.yarn/patches/eslint-plugin-header-npm-3.1.1-402265ec6f.patch"
+    eslint-plugin-header: "npm:^3.1.1"
     eslint-plugin-import: "npm:~2.31.0"
     eslint-plugin-jsdoc: "npm:^48.0.2"
     eslint-plugin-react: "npm:^7.37.4"
@@ -7293,7 +7293,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint-plugin-header@npm:3.1.1":
+"eslint-plugin-header@npm:^3.1.1":
   version: 3.1.1
   resolution: "eslint-plugin-header@npm:3.1.1"
   peerDependencies:
@@ -7302,15 +7302,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint-plugin-header@patch:eslint-plugin-header@npm%3A3.1.1#~/.yarn/patches/eslint-plugin-header-npm-3.1.1-402265ec6f.patch":
-  version: 3.1.1
-  resolution: "eslint-plugin-header@patch:eslint-plugin-header@npm%3A3.1.1#~/.yarn/patches/eslint-plugin-header-npm-3.1.1-402265ec6f.patch::version=3.1.1&hash=4c78e9"
-  peerDependencies:
-    eslint: ">=7.7.0"
-  checksum: 94c79e8f45c724df516cf786b47db75f2670f781cb8acaf09fd7fbd4922fefdb7668128317452aef8c52dfda0a152a7eb74099d4608b265689c00fc386bbe372
-  languageName: node
-  linkType: hard
-
 "eslint-plugin-import@npm:~2.31.0":
   version: 2.31.0
   resolution: "eslint-plugin-import@npm:2.31.0"