Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger boxes for bigger files #331

Open
sanoodles opened this issue Nov 6, 2022 · 4 comments
Open

Bigger boxes for bigger files #331

sanoodles opened this issue Nov 6, 2022 · 4 comments
Labels
core dependency tree generation viz visualization enhancement, graphviz

Comments

@sanoodles
Copy link

Please provide an option to make files that weight more KB look bigger in the diagram.

Perhaps with a logarithmic relationship between file weight and box size so that a few very big files don't take too much screen space.

If bigger boxes is technically challenging, try just bigger font sizes (which hopefully will stretch the box along) or greater background/foreground contrast. With logarithmic relationships as well.

@PabloLION PabloLION added viz visualization enhancement, graphviz core dependency tree generation labels Jan 28, 2023
@PabloLION
Copy link
Collaborator

PabloLION commented Jan 28, 2023

Two features to add

  1. get file size (core)
  2. change node/&font size in graphviz.

@PabloLION
Copy link
Collaborator

PabloLION commented Jan 28, 2023

Also, should we use a different style (including size, if cannot resolve the size of the dynamically imported package)
if so, what style / size should we use?
This is also for #344 (comment)?

@sanoodles
Copy link
Author

I'm not sure if you are asking me, but I assume yes.

I think that how to depict dynamic imports is a different topic on which I have no strong opinion.

I only know that the type of an import could not imply a different box style because other consumers might import it in different ways (eg. static, or for the side effects (yuk))

So if anything, I would paint the arrow differently. But mind:

  • Dashed arrows already symbolize something else in UML. I would overlap as little as possible with UML to minimize confusion.
  • Maybe use a lower contrast color arrow
  • Maybe and if easy enough, add a label with the word "dynamic" next to the middle of the arrow

@PabloLION
Copy link
Collaborator

PabloLION commented Jan 29, 2023

Thanks for the ideas @sanoodles . It seems to me that the current graph is not using same symbols as the UML system. I just checked that the UML uses dashed line with open arrow for Dependency relationships.
I'll edit my posts before and try to work on it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core dependency tree generation viz visualization enhancement, graphviz
Projects
None yet
Development

No branches or pull requests

2 participants