Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIDM-205] feat(pdf): remove pdf generation and dependencies #92

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

CianoDanilo
Copy link
Contributor

@CianoDanilo CianoDanilo commented Feb 20, 2025

Removed PDF generation and related dependencies

List of Changes

Motivation and Context

PDF generation is an unused feature. Since at the moment the application generates a PDF but does not attach it to the email, we can and should remove the PDF generation in order to lower the API response time and avoid possible OOM errors caused by the creation of many chromium processes (used by puppeteer) under heavy load.

How Has This Been Tested?

Load tests
Completed payment in dev env

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6aefe2f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage        ?   87.58%           
=======================================
  Files           ?       10           
  Lines           ?      306           
  Branches        ?       39           
=======================================
  Hits            ?      268           
  Misses          ?       31           
  Partials        ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pietro-tota pietro-tota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@CianoDanilo CianoDanilo merged commit 9a6194f into main Feb 21, 2025
10 of 15 checks passed
@CianoDanilo CianoDanilo deleted the PIDM-205-remove-pdf-gen branch February 21, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants