-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-2666] FastLogin expiration Banner #6736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate for each login succeded
…ble if threshold value is 0 or higher
…e equal to threshold value
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
shadowsheep1
requested changes
Feb 19, 2025
Ladirico
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Depends on this PR
Short description
This PR implements the FastLogin notification banner in the messages section, displayed when the days left until the
expirationDate
are lower than or equal to the remotethreshold
valueList of changes proposed in this pull request
content
definitions source urlloginPreferences
in order to handle the local persistedshowSessionExpirationBanner
valueLoginExpirationBanner
into thelandingScreenBannerMap
isSessionExpirationBannerRenderableSelector
in order to ensure it works correctlyDemo
Fast Login
iOS-fast-login.mov
android-fast-login.mov
Standard Login
iOS-standard-login.mov
android-standard-login.mov
Note
For standard login, it is currently not necessary to display the session expiration banner. However, it can be enabled by setting the
standardLogin
threshold field in the remote configuration.How to test
This feature can be tested in a local environment by running the dev server from the branch of this PR. This will allow testing different scenarios by changing the values of
expirationDate
andloginConfig
as needed.As for the production environment, a proxy tool will be required to manipulate the
expirationDate
field value as needed.