Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [IOPLT-956] Converts all locales translations files into JSON objects #6735

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Feb 19, 2025

Short description

This PR aims to convert and removes all the YAML files into JSON static objects containing all the locale strings.

List of changes proposed in this pull request

  • Removes YAML files for translations
  • Removes all other files containing static texts
  • Adds translations into JSON files

How to test

Check the locales generation scripts and app translation to be properly handled.

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.30%. Comparing base (6d90444) to head (5e5223a).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6735   +/-   ##
=======================================
  Coverage   50.30%   50.30%           
=======================================
  Files        1563     1563           
  Lines       32510    32510           
  Branches     7350     7352    +2     
=======================================
  Hits        16353    16353           
  Misses      16117    16117           
  Partials       40       40           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d90444...5e5223a. Read the comment docs.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I didn't notice any regressions in B&P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants