-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOPLT-956] Converts all locales translations files into JSON objects #6735
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6735 +/- ##
=======================================
Coverage 50.30% 50.30%
=======================================
Files 1563 1563
Lines 32510 32510
Branches 7350 7352 +2
=======================================
Hits 16353 16353
Misses 16117 16117
Partials 40 40 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I didn't notice any regressions in B&P
Short description
This PR aims to convert and removes all the YAML files into JSON static objects containing all the locale strings.
List of changes proposed in this pull request
How to test
Check the locales generation scripts and app translation to be properly handled.