Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-2634] Implement Zendesk FAQ Banner in the accesso_a_io subCategories screen #6714

Merged
merged 10 commits into from
Feb 20, 2025

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Feb 13, 2025

Important

Depends on this PR on io-services-metadata

Short description

This PR updates the content definition url source and implements the Zendesk sub categories Banner visualization in relation to the subCategories configuration.

List of changes proposed in this pull request

  • Updated the content definition url in the scripts/generate-api-models.sh file
  • Integrated the Banner educational in the ts/features/zendesk/screens/ZendeskChooseSubCategory.tsx screen

Demo

iOS Android
iOS-zendesk-faq-banner.mp4
android-zendesk-faq-banner.mp4

Important

The Banner's pictogram has been changed after the demo has been recorded:

How to test

This scenario can be tested in the local environment.
Run the io-dev-api-server from this branch, then repeat the steps shown in the demo videos and ensure that everything works properly.

@ChrisMattew ChrisMattew self-assigned this Feb 13, 2025
@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.33%. Comparing base (bbbbd94) to head (cf84e46).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx 40.00% 6 Missing ⚠️
ts/utils/object.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6714      +/-   ##
==========================================
- Coverage   50.34%   50.33%   -0.01%     
==========================================
  Files        1564     1564              
  Lines       32554    32564      +10     
  Branches     7373     7379       +6     
==========================================
+ Hits        16389    16392       +3     
+ Misses      16124    16118       -6     
- Partials       41       54      +13     
Files with missing lines Coverage Δ
ts/utils/object.ts 66.66% <0.00%> (-33.34%) ⬇️
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx 67.64% <40.00%> (-9.28%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbbbd94...cf84e46. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using local and production envirment and works correctly. Good Job! LGTM! 🚀

@Ladirico Ladirico added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants