Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PE-882] CGN new discounts count #6607

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

freddi301
Copy link
Collaborator

Short description

Replaced badge label of "novità" with actual new discounts count.

List of changes proposed in this pull request

  • change label

How to test

  • to test with dev-api-server you need feat: [PE-882] Add new discounts number io-dev-api-server#455
  • login into the app
  • go to carta giovani nazionale trough portafoglio (add the card if necessary)
  • go to discount list by pressing "scopri opportunià"
  • press "by partner" tab
  • check that the badges contain numbers instead of a fixed label
  • press "by category" tab
  • press on any category
  • check that the badges contain numbers instead of a fixed label

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue PE-882

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.50%. Comparing base (58557e7) to head (c995a8d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../cgn/components/merchants/CgnMerchantsListView.tsx 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (58557e7) and HEAD (c995a8d). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (58557e7) HEAD (c995a8d)
9 5
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6607      +/-   ##
==========================================
- Coverage   46.97%   40.50%   -6.47%     
==========================================
  Files        1550     1410     -140     
  Lines       32003    29809    -2194     
  Branches     7232     6732     -500     
==========================================
- Hits        15033    12075    -2958     
- Misses      16935    17703     +768     
+ Partials       35       31       -4     
Files with missing lines Coverage Δ
.../cgn/components/merchants/CgnMerchantsListView.tsx 11.11% <0.00%> (-5.56%) ⬇️

... and 513 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58557e7...c995a8d. Read the comment docs.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, pay attention to that edge case

@freddi301 freddi301 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 93bd0a8 Jan 17, 2025
21 checks passed
@freddi301 freddi301 deleted the PE-882-cgn-new-discounts-count branch January 17, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants