packit-fedora-ci: Scratch builds on a PR to multiple branches overwrite each other

[LecrisUT]

What happened? What is the problem?

Let's say there is a PR to update rawhide which triggers a packit-scratch-build. Then if we have another PR to f42 using the same commit (e.g. merging rawhide to f42 later on), the latter f42 scratch-build will overwrite the rawhide one.

This is what happened here, where you see only 1 packit-scratch-build job, but fedora-ci and zuul are correctly doubled:

• https://src.fedoraproject.org/rpms/python-scikit-build-core/pull-request/75
• https://src.fedoraproject.org/rpms/python-scikit-build-core/c/50f910da98b7516499f4ae8b4a71ed5cbb6818a8

[lachmanfrantisek]

Hi @LecrisUT, good catch.

Slightly related to this is that if we share the commit between multiple pull-requests, the all the statuses are visible across all the pull requests (e.g. see here).

This comes from the way how CI checks are implemented (it is a commit status in reality), but we might need to at least make clear what status comes from what branch to better understand this.

---

Historical note: Pagure used to do statuses for pull-request instead of commits which fixes this issue but makes it really hard to reliably update the status on rebases/pushes/... Maybe we can check how this works on Forgejo and if there isn't a way to apply statues for commit AND pull requests.

[LecrisUT]

Seems like the core issue is

packit-service/packit_service/worker/reporting/reporters/pagure.py

Line 54 in 33b1614

uid = hashlib.sha256(check_name.encode()).hexdigest()[:32]

where it should include the target branch as well. My thought is to include that in check_name itself because it would clarify the target branch in both pagure UI and notifications.

Maybe we can check how this works on Forgejo and if there isn't a way to apply statues for commit AND pull requests.

Afaict from Github, the status check is applied to both commit and PR if it's triggered in both. Sometimes I have commit status from my fork show up in the PR. It does not display in the PR though, so there is some magic there. Forgejo api shows that there is some context that you can set, but 🤷 for what that means.

[lbarcziova]

where it should include the target branch as well. My thought is to include that in check_name itself because it would clarify the target branch in both pagure UI and notifications.

@LecrisUT yes you are correct, we discussed this on our standup today and also concluded the inclusion of the target branch will both be beneficial and fix the issue.