Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
torus(h, phases)
function wraps some axes of an L-dimensional AbstractHamiltonians, adding fixed Bloch phases along the wrapped axes.Here we introduce
@torus(h, phases, ϕ)
, which adds a parameterϕ
(or whatever other name we provide as the third argument) to the result (which is thus a ParametricHamiltonian). This parameter can be used to adjust the Bloch phase. ϕ takes the form of a tuple or an AbstractVector of length equal to the number of wrapped axes.We also generalize
torus
, so that we can dotorus(h, wrapped_axes::SVector)
(and similarly with@torus
), so that the axes given bywrapped_axes
are wrapped with phase zero. This is a convenience form that may be easier to use. For example we can replacetorus(h, (:, 0, :))
withtorus(h, SA[2])
to wrap along axis 2.We have furthermore improved the detection algorithm for modifier collisions.