Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow integrand params to be different from integration path params #330

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

pablosanjose
Copy link
Owner

Closes #329 (implements fix 1 therein)

When the integrand is built using params, these are bundled into a closure, together with omegamap, which simplifies the JosephsonIntegrand and DensityMatrixIntegrand structs.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.44%. Comparing base (f64e499) to head (e516fcd).

Files with missing lines Patch % Lines
src/observables.jl 93.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   92.43%   92.44%           
=======================================
  Files          41       41           
  Lines        7075     7077    +2     
=======================================
+ Hits         6540     6542    +2     
  Misses        535      535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

add tests
@pablosanjose pablosanjose changed the title Pointkwargs Disallow integrand params to be different from integration path params Jan 29, 2025
@pablosanjose pablosanjose merged commit 9af8efb into master Jan 29, 2025
9 checks passed
@pablosanjose pablosanjose deleted the pointkwargs branch January 29, 2025 17:06
@pablosanjose pablosanjose mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add syntax to pass keword parameters to Quantica.point
2 participants