More general Quantica.gaps #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docstring docstring
pablosanjose
added a commit
that referenced
this pull request
Nov 28, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 39 39
Lines 6906 6907 +1
=======================================
+ Hits 6386 6387 +1
Misses 520 520 ☔ View full report in Codecov by Sentry. |
pablosanjose
added a commit
that referenced
this pull request
Nov 28, 2024
* Better meanfield docstrings simplifications and fixes fix dispatch for N=2 fixes to CompressedOrbitalMatrix indexing serialize(T, ::OrbitalSliceArray) fix test * fix test * doctests fixes * correctness fixes * code reordering * missing method * another fix * fix for case fock = nothing * force hermiticity in CompressedOrbitalMatrix * only compute ρ once per meanfield also, assume Hermtian Hamiltonian in Schur ρ solver * skip size threshold in docs for api.md * fix doc make * don't drop structural zeros in Fock potential * rebase on Quantica.gaps PR #324 * docs [skip tests]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now pass keyword arguments to the ArnoldiMethod eigensolver used by
gaps