Bugfix: ensure correct dealiasing of lattices after attach

src/types.jl

@@ -1691,7 +1691,7 @@ LinearAlgebra.ishermitian(h::ParametricHamiltonian) =
     argerror("`ishermitian(::ParametricHamiltonian)` not supported, as the result can depend on the values of parameters.")
 
 copy_lattice(p::ParametricHamiltonian) = ParametricHamiltonian(
-    copy_lattice(p.hparent), p.h, p.modifiers, p.allptrs, p.allparams)
+    p.hparent, copy_lattice(p.h), p.modifiers, p.allptrs, p.allparams)
 
 copy_harmonics_shallow(p::ParametricHamiltonian) = ParametricHamiltonian(
     copy_harmonics_shallow(p.hparent), copy_harmonics_shallow(p.h), p.modifiers, p.allptrs, p.allparams)

test/test_greenfunction.jl

@@ -531,7 +531,7 @@ end
     @test typeof(ρ0sol) == typeof(ρsol)
 end
 
-@testset "aliasing" begin
+@testset "greenfunction aliasing" begin
     # Issue #267
     g = LP.linear() |> hamiltonian(@hopping((; q = 1) -> q*I), orbitals = 2) |> greenfunction
     g´ = Quantica.minimal_callsafe_copy(g)
@@ -561,6 +561,13 @@ end
     @test g.contacts.selfenergies[2].solver.hlead[(0,)] === g.contacts.selfenergies[1].solver.hlead[(0,)]
     @test g.contacts.selfenergies[2].solver.hlead[(1,)] === g.contacts.selfenergies[1].solver.hlead[(-1,)]
     @test g.contacts.selfenergies[2].solver.hlead[(-1,)] === g.contacts.selfenergies[1].solver.hlead[(1,)]
+
+    # ensure full dealiasing of lattices in attach
+    model = hopping(SA[1 0; 0 -1]) + @onsite((; µ = 0) -> SA[-µ 0; 0 µ])
+    h = LP.linear() |> hamiltonian(model, orbitals = 2)
+    glead = h |> greenfunction(GS.Schur(boundary = 0))
+    g = h |> attach(glead, cells = 1) |> greenfunction(GS.Schur(boundary = 0));
+    @test sites(lattice(h)) == [SA[0.0]]
 end
 
 @testset "meanfield" begin