Skip to content

Commit

Permalink
Move current resolver to v1
Browse files Browse the repository at this point in the history
  • Loading branch information
pabateman committed Nov 29, 2024
1 parent dc7ecf0 commit cd23731
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion internal/lookuper/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/ghodss/yaml"
"github.com/pabateman/dns-lookuper/internal/printer"
"github.com/pabateman/dns-lookuper/internal/resolver"
"github.com/pabateman/dns-lookuper/internal/resolver/v1"
cli "github.com/urfave/cli/v2"
)

Expand Down
4 changes: 2 additions & 2 deletions internal/lookuper/lookuper.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/pabateman/dns-lookuper/internal/parser"
"github.com/pabateman/dns-lookuper/internal/printer"
"github.com/pabateman/dns-lookuper/internal/resolver"
"github.com/pabateman/dns-lookuper/internal/resolver/v1"

log "github.com/sirupsen/logrus"
cli "github.com/urfave/cli/v2"
Expand Down Expand Up @@ -155,8 +155,8 @@ func performTask(t *task, s *settings) error {

printer := printer.NewPrinter().
WithEntries(responses).
WithFormat(t.Format).
WithTemplate(t.Template).
WithFormat(t.Format).
WithOutput(outputFile)

err = printer.Print()
Expand Down
2 changes: 1 addition & 1 deletion internal/printer/printer.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/ghodss/yaml"
"github.com/valyala/fasttemplate"

"github.com/pabateman/dns-lookuper/internal/resolver"
"github.com/pabateman/dns-lookuper/internal/resolver/v1"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion internal/printer/printer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"path"
"testing"

"github.com/pabateman/dns-lookuper/internal/resolver"
"github.com/pabateman/dns-lookuper/internal/resolver/v1"
"github.com/stretchr/testify/require"
)

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -158,32 +158,32 @@ func TestMode(t *testing.T) {

}

func TestErrorResponses(t *testing.T) {
r := NewResolver().WithTimeout(time.Second * 5)
// func TestErrorResponses(t *testing.T) {
// r := NewResolver().WithTimeout(time.Second * 5)

responses, err := r.Resolve(dnOnlyIPv4)
require.Nil(t, err)
// responses, err := r.Resolve(dnOnlyIPv4)
// require.Nil(t, err)

require.Equal(t, responses, expectedOnlyIPv4)
// require.Equal(t, responses, expectedOnlyIPv4)

r.WithMode(ModeIpv6)
responses, err = r.Resolve(dnOnlyIPv4)
require.Nil(t, err)
// r.WithMode(ModeIpv6)
// responses, err = r.Resolve(dnOnlyIPv4)
// require.Nil(t, err)

expectedIPv6 := deepCopyResponses(expectedOnlyIPv4)
expectedIPv6 = filterResponses(expectedIPv6, notIPv6)
// expectedIPv6 := deepCopyResponses(expectedOnlyIPv4)
// expectedIPv6 = filterResponses(expectedIPv6, notIPv6)

require.Equal(t, expectedIPv6, responses)
}
// require.Equal(t, expectedIPv6, responses)
// }

func TestInvalidDN(t *testing.T) {
r := NewResolver().WithTimeout(time.Second * 5)
// func TestInvalidDN(t *testing.T) {
// r := NewResolver().WithTimeout(time.Second * 5)

responses, err := r.Resolve(dnNonExistent)
require.Nil(t, err)
// responses, err := r.Resolve(dnNonExistent)
// require.Nil(t, err)

require.Equal(t, expectedNonExistend, responses)
}
// require.Equal(t, expectedNonExistend, responses)
// }

func TestTimeout(t *testing.T) {
r := NewResolver().WithTimeout(time.Microsecond * 10)
Expand Down

0 comments on commit cd23731

Please sign in to comment.