Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See if we can again make working draft version of P4Runtime spec to update on every merge to this repo #533

Open
jafingerhut opened this issue Jan 19, 2025 · 3 comments
Open

See if we can again make working draft version of P4Runtime spec to update on every merge to this repo #533

jafingerhut opened this issue Jan 19, 2025 · 3 comments
Labels
asciidoc-issue

Comments

@jafingerhut
Copy link
Contributor

The "working draft" version of the spec on this page: https://p4.org/specs/

is still the one last generated in 2024-Dec from Madoko source, even after this PR was merged in to change the source to AsciiDoc: #510

So there is something missing in this repo's CI workflow on merges that isn't set up in order to make the new working draft versions to appear there. I'm not sure what yet.
@antoninbas
Copy link
Member

antoninbas commented Jan 21, 2025 •
edited
Loading

@jafingerhut you can check this to see the location where the p4.org website expects the generated html file to be checked in: view-source:https://p4.org/p4-spec/docs/p4runtime-spec-working-draft-html-version.html

@antoninbas
Copy link
Member

(You need to check the source as the link itself is a Javascript program which loads the Github source file)

@jafingerhut
Copy link
Contributor Author

@jafingerhut you can check this to see the location where the p4.org website expects the generated html file to be checked in: view-source:https://p4.org/p4-spec/docs/p4runtime-spec-working-draft-html-version.html

Yes, it has been set up that way for over a year with no changes. The contents I see when viewing the source there show this being the URL that is actually used for showing the P4Runtime spec HTML contents:

https://raw.githubusercontent.com/p4lang/p4runtime/gh-pages/spec/main/P4Runtime-Spec.html

The full result of view-source is shown below, for the curious:

<!DOCTYPE html>
<html>
<head>
<script>
const url = "https://raw.githubusercontent.com/p4lang/p4runtime/gh-pages/spec/main/P4Runtime-Spec.html";
const req = new XMLHttpRequest();
req.open("GET", url, true);
req.onload = (_) => {
    const doc = document.open("text/html", "replace");
    doc.write( req.response );
    doc.close();
};
req.send(null)
</script>
</head>
<body></body>
</html>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
asciidoc-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jafingerhut @antoninbas