-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port to 25 #245
port to 25 #245
Conversation
xgp
commented
Jun 10, 2024
- ported to keycloak 25
- cleaned old team entities
- still need to get events-dependent tests working and import config
…dent tests working and import config
@rtufisi the |
Sure. I will take a look |
@@ -807,7 +790,7 @@ public void testAddGetDeleteRolesBulk() throws Exception { | |||
} | |||
}; | |||
resp = | |||
SimpleHttp.doPut(url, httpClient) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that the latest implementation: https://github.com/keycloak/keycloak/blob/ca0833b2e48ef3fac6c524bcb5b0680a73fdb6fa/server-spi-private/src/main/java/org/keycloak/broker/provider/util/SimpleHttp.java#L4 has a new implementation with signature doPut(String url, HttpClient client, long maxConsumedResponseSize)
Couldn't we use the default?
default long getMaxConsumedResponseSize() {
return DEFAULT_MAX_CONSUMED_RESPONSE_SIZE;
}
and not create a new class?
E.q:
public static SimpleHttp doPut(String url, KeycloakSession session) {
HttpClientProvider provider = session.getProvider(HttpClientProvider.class);
return doPut(url, provider.getHttpClient(), provider.getMaxConsumedResponseSize());
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That takes a KeycloakSession
which we don't have. The one that takes an HttpClient
is protected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry . I didn't saw the access modifier.