Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-457: Switch Reverse Proxy to Nginx from Apache 2. #66

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

enyachoke
Copy link
Contributor

The PR switches the Proxy to Nginx to get around the CSFR issue here https://mekomsolutions.atlassian.net/browse/OZ-457

@enyachoke enyachoke requested review from rbuisson and mks-d January 9, 2024 14:54
@mks-d mks-d changed the title OZ-457: Switch Reverse Proxy to Nginx OZ-457: Switch Reverse Proxy to Nginx from Apache 2. Jan 9, 2024
Copy link
Contributor

@mks-d mks-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I leave the validation to @rbuisson.

Copy link
Contributor

@rbuisson rbuisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good.
Thanks. Minor changes requested.

scripts/utils.sh Outdated
function setApache2Hostnames {
echo "$INFO Exporting Apache 2 hostnames..."
function setNginxHostnames {
echo "$INFO Exporting Nginx hostnames..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Apache HTTPD - Entry point for the application.

Should be renamed to:

# Nginx - Entry point for the application.

@rbuisson rbuisson merged commit d477745 into main Jan 9, 2024
2 checks passed
@rbuisson rbuisson deleted the OZ-457 branch May 24, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants