Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-573: Add support for SSO with necessary configurations #120

Merged
merged 22 commits into from
Dec 4, 2024

Conversation

corneliouzbett
Copy link
Contributor

@corneliouzbett corneliouzbett commented Nov 4, 2024

Issue: https://mekomsolutions.atlassian.net/browse/OZ-573

This PR does the following;

  • Introduce Docker Compose files with the suffix -sso to provide necessary configurations for SSO support.
  • Adds configurability based on the environment variable ENABLE_SSO.
  • Create helper scripts start-with-sso.sh and start-demo-with-sso.sh to enable SSO and start the respective services.
  • Updates scripts/utils.sh to parse and include SSO-specific Docker Compose files when ENABLE_SSO is set to true.

@corneliouzbett corneliouzbett marked this pull request as ready for review November 21, 2024 12:20
bundled-docker/frontend/Dockerfile Outdated Show resolved Hide resolved
bundled-docker/senaite/Dockerfile-sso Outdated Show resolved Hide resolved
bundled-docker/postgresql/Dockerfile Outdated Show resolved Hide resolved
bundled-docker/postgresql/Dockerfile Outdated Show resolved Hide resolved
bundled-docker/openmrs/Dockerfile-sso Outdated Show resolved Hide resolved
scripts/start-demo-with-sso.sh Show resolved Hide resolved
scripts/start-with-sso.sh Outdated Show resolved Hide resolved
scripts/start-demo-with-sso.sh Outdated Show resolved Hide resolved
scripts/utils.sh Outdated Show resolved Hide resolved
@enyachoke enyachoke self-requested a review December 3, 2024 09:26
Copy link
Contributor

@VaishSiddharth VaishSiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two suggestions.

docker-compose-openmrs.yml Show resolved Hide resolved
scripts/utils.sh Outdated Show resolved Hide resolved
@corneliouzbett corneliouzbett merged commit 88c635f into main Dec 4, 2024
2 checks passed
@corneliouzbett corneliouzbett deleted the OZ-573 branch December 4, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants