WIP: Normalize file names before using them as keys #12002
Draft
+26
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
work/fix-filename-normalization2
branch
3 times, most recently
from
dd40586 to
039c965
Compare
erikjv
force-pushed
the
work/fix-filename-normalization2
branch
from
039c965 to
3641217
Compare
| @@ -545,6 +545,9 @@ Folder *FolderMan::addFolderInternal( | |||
| Folder *FolderMan::folderForPath(const QString &path, QString *relativePath) | |||
| { | |||
| QString absolutePath = QDir::cleanPath(path) + QLatin1Char('/'); | |||
| if (!Utility::isLinux()) { | |||
There was a problem hiding this comment.
Out of curiosity: why not use an ifdef? These are all ifs which never change at runtime.
On macOS the filenames on disk are stored in NFD form. When the original filename on the server was in NFC form, the filenames wouldn't match, and a MOVE or DELETE+PUT would be triggered. This changes converts all filenames to NFC form during local discovery.
DeepDiver1975
force-pushed
the
work/fix-filename-normalization2
branch
from
3641217 to
526a4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.