🚨 first is nullable

tests/Functional/AuditingTest.php

@@ -127,6 +127,8 @@ public function itWillAuditTheRetrievedEvent()
 
         $audit = Audit::first();
 
+        $this->assertNotNull($audit);
+
         $this->assertEmpty($audit->old_values);
 
         $this->assertEmpty($audit->new_values);
@@ -150,6 +152,8 @@ public function itWillAuditTheCreatedEvent()
 
         $audit = Audit::first();
 
+        $this->assertNotNull($audit);
+
         $this->assertEmpty($audit->old_values);
 
         self::Assert()::assertArraySubset([
@@ -187,6 +191,8 @@ public function itWillAuditTheUpdatedEvent()
 
         $audit = Audit::first();
 
+        $this->assertNotNull($audit);
+
         self::Assert()::assertArraySubset([
             'content'      => 'N/A',
             'published_at' => null,
@@ -220,6 +226,8 @@ public function itWillAuditTheDeletedEvent()
 
         $audit = Audit::first();
 
+        $this->assertNotNull($audit);
+
         self::Assert()::assertArraySubset([
             'title'        => 'How To Audit Eloquent Models',
             'content'      => 'N/A',
@@ -252,6 +260,8 @@ public function itWillAuditTheRestoredEvent()
 
         $audit = Audit::first();
 
+        $this->assertNotNull($audit);
+
         $this->assertEmpty($audit->old_values);
 
         self::Assert()::assertArraySubset([
@@ -359,6 +369,8 @@ public function itWillAuditUsingTheDefaultDriver()
 
         $audit = Audit::first();
 
+        $this->assertNotNull($audit);
+
         $this->assertEmpty($audit->old_values);
 
         self::Assert()::assertArraySubset([
@@ -476,10 +488,12 @@ public function itHandlesJsonColumnsCorrectly()
         $article->config = ['articleIsGood' => false, 'authorsJob' => 'vampire'];
         $article->save();
 
-        /** @var Audit $audit */
         $audit = $article->audits()->skip(1)->first();
-        $this->assertSame(false, $audit->getModified()['config']['new']['articleIsGood']);
-        $this->assertSame(true, $audit->getModified()['config']['old']['articleIsGood']);
+
+        $this->assertNotNull($audit);
+
+        $this->assertFalse($audit->getModified()['config']['new']['articleIsGood']);
+        $this->assertTrue($audit->getModified()['config']['old']['articleIsGood']);
     }
 
     /**
@@ -493,8 +507,10 @@ public function canAddAdditionalResolver()
 
         $article = factory(Article::class)->create();
 
-        $this->assertTrue(true);
         $audit = $article->audits()->first();
+
+        $this->assertNotNull($audit);
+
         $this->assertSame(1, (int)$audit->tenant_id);
     }
 
@@ -510,6 +526,9 @@ public function canDisableResolver()
         $article = factory(Article::class)->create();
 
         $audit = $article->audits()->first();
+
+        $this->assertNotNull($audit);
+
         $this->assertEmpty($audit->ip_address);
     }
 

tests/Unit/AuditTest.php

@@ -29,8 +29,9 @@ public function itResolvesAuditData()
             'published_at' => $now,
         ]);
 
-        /** @var Audit $audit */
         $audit = $article->audits()->first();
+        $this->assertNotNull($audit);
+
         $resolvedData = $audit->resolveData();
         $this->assertCount(15, $resolvedData);
 
@@ -79,6 +80,8 @@ public function itResolvesAuditDataIncludingUserAttributes()
 
         $audit = $article->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $this->assertCount(21, $resolvedData = $audit->resolveData());
 
         self::Assert()::assertArraySubset([
@@ -127,6 +130,8 @@ public function itReturnsTheAppropriateAuditableDataValues()
             'published_at' => Carbon::now(),
         ])->audits()->first();
 
+        $this->assertNotNull($audit);
+
         // Resolve data, making it available to the getDataValue() method
         $this->assertCount(21, $audit->resolveData());
 
@@ -179,6 +184,8 @@ public function itReturnsTheAppropriateAuditableDataValuesWithCustomCastValueObj
 
         $lastAudit = $article->audits()->skip(1)->first();
 
+        $this->assertNotNull($lastAudit);
+
         $this->assertEquals(new Money('24.68', 'USD'), $lastAudit->getModified()['price']['new']);
         $this->assertEquals(new Money('12.45', 'USD'), $lastAudit->getModified()['price']['old']);
     }
@@ -191,6 +198,8 @@ public function itReturnsAuditMetadataAsArray()
     {
         $audit = factory(Article::class)->create()->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $this->assertCount(10, $metadata = $audit->getMetadata());
 
         self::Assert()::assertArraySubset([
@@ -217,6 +226,8 @@ public function itReturnsProperCommandLineInUrlAuditMetadata()
     {
         $audit = factory(Article::class)->create()->audits()->first();
 
+        $this->assertNotNull($audit);
+
         self::Assert()::assertEquals($audit->getMetadata()['audit_url'], 'vendor/bin/phpunit tests/Unit/AuditTest.php --group command-line-url-resolver');
     }
 
@@ -235,9 +246,10 @@ public function itReturnsAuditMetadataIncludingUserAttributesAsArray()
 
         $this->actingAs($user);
 
-        /** @var Audit $audit */
         $audit = factory(Article::class)->create()->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $this->assertCount(16, $metadata = $audit->getMetadata());
 
         self::Assert()::assertArraySubset([
@@ -268,6 +280,8 @@ public function itReturnsAuditMetadataAsJsonString()
     {
         $audit = factory(Article::class)->create()->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $metadata = $audit->getMetadata(true, JSON_PRETTY_PRINT);
 
         $created_at = $audit->getSerializedDate($audit->created_at);
@@ -305,6 +319,8 @@ public function itReturnsAuditMetadataIncludingUserAttributesAsJsonString()
 
         $audit = factory(Article::class)->create()->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $metadata = $audit->getMetadata(true, JSON_PRETTY_PRINT);
 
         $created_at = $audit->getSerializedDate($audit->created_at);
@@ -348,6 +364,8 @@ public function itReturnsAuditableModifiedAttributesAsArray()
             'published_at' => $now,
         ])->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $this->assertCount(5, $modified = $audit->getModified());
 
         self::Assert()::assertArraySubset([
@@ -377,14 +395,15 @@ public function itReturnsAuditableModifiedAttributesAsJsonString()
     {
         $now = Carbon::now()->second(0)->microsecond(0);
 
-        /** @var Audit $audit */
         $audit = factory(Article::class)->create([
             'title'        => 'How To Audit Eloquent Models',
             'content'      => 'First step: install the laravel-auditing package.',
             'reviewed'     => 1,
             'published_at' => $now,
         ])->audits()->first();
 
+        $this->assertNotNull($audit);
+
         $modified = $audit->getModified(true, JSON_PRETTY_PRINT);
 
         $serializedDate = $audit->getSerializedDate($now);
@@ -491,4 +510,4 @@ class itReturnsDecodedAuditableAttributesArticle extends Article
         'title'   => Base64Encoder::class,
         'content' => LeftRedactor::class,
     ];
-}
+}

tests/Unit/AuditableTest.php

@@ -798,8 +798,10 @@ public function itExcludesAttributesFromExclude()
         $model->reviewed = 1;
         $model->save();
 
-        /** @var Audit $audit */
-        $audit = Audit::all()->first();
+        $audit = Audit::first();
+
+        $this->assertNotNull($audit);
+
         $this->assertArrayNotHasKey('title', $audit->getModified());
     }
 
@@ -1022,6 +1024,8 @@ public function itWorksOnTimesRestoredCorrectly()
 
         $model = Article::first();
 
+        $this->assertNotNull($model);
+
         $this->assertEquals($model->published_at, $originalStart);
 
         $model->published_at = new Carbon('2022-01-01 12:30:00');
@@ -1067,6 +1071,8 @@ public function itFailsToTransitionWhenTheAuditAuditableIdDoesNotMatchTheModelId
 
         $firstModel = factory(Article::class)->create();
         $firstAudit = $firstModel->audits()->first();
+        $this->assertNotNull($firstAudit);
+
         $firstAudit->auditable_id = $firstModel->id;
 
         $secondModel = factory(Article::class)->create();