Enchance permission string parsing #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cache_ip option to aggregators->peers Update documentation
Update perm_handler() to have stricter error checking by using regex's for both the perm string format and the perm octal-in-a-string format.
|
@morrone Thanks for throwing this together! I tweaked it to remove python3 octal support as some people found that confusing. I appreciate your help putting this together =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the permission string parsing from PR #1564.
Add full checking of the string permission representation: (r|-)(w|-)-(r|-)(w|-)-(r|-)(w|-)- )
Add checking of an octal-number-in-a-string, at least verifying that the number looks like octal, and doesn't have excess digits.
(We could perhaps also verify that the "x" bits are not set, but do not do so in this patch.)